fix: CommonJS types in all packages #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
previously approved these changes
Jan 30, 2025
| "build:cts": "node -e \"fs.copyFileSync('dist/esm/index.d.ts', 'dist/cjs/index.d.cts')\"", | ||
| "build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts", |
There was a problem hiding this comment.
This isn't really necessary since the compat package generates no types.ts or types.cts file. But it's okay to use the build-cts script if we'd like to stay consistent across packages.
There was a problem hiding this comment.
Yeah, I just wanted things to be consistent. That way, if we ever add a types.ts, we won't get confused when the same bug gets introduced later.
Co-authored-by: Francesco Trotta <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix CommonJS types in all packages.
What changes did you make? (Give an overview)
build-cts.jsto be a top-level tooleslint.config.jsto allowconsole.logintools/**Related Issues
Is there anything you'd like reviewers to focus on?