Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zeroconf to >=0.128.4,<1.0 #791

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Bump zeroconf to >=0.128.4,<1.0 #791

merged 1 commit into from
Dec 12, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 12, 2023

0.128.4 has some significant bug fixes and the current requirement of 0.36.0 is missing some calls in ServiceInfo that we currently call so it does not work

0.128.4 has some significant bug fixes and the current requirement
of 0.36.0 is missing some calls in ServiceInfo that we currently call
so it does not work
@bdraco bdraco merged commit 81598d8 into main Dec 12, 2023
8 checks passed
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fc8e9c) 100.00% compared to head (20dc010) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #791   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2402      2402           
=========================================
  Hits          2402      2402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco deleted the bump_zeroconf branch December 12, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant