Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Datetime date entity #824

Merged
merged 16 commits into from
Mar 7, 2024
Merged

Conversation

RFDarter
Copy link
Contributor

@RFDarter RFDarter commented Feb 12, 2024

@bdraco bdraco added the waiting-for-esphome Indicates the PR is waiting for the esphome main repo code approval label Feb 12, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cfab790) to head (9d217dd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #824   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2438      2449   +11     
=========================================
+ Hits          2438      2449   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Feb 17, 2024

Please generate the protobuf files with

          docker run \
            -v "$PWD":/aioesphomeapi \
            ghcr.io/esphome/aioesphomeapi-proto-builder:latest

@RFDarter
Copy link
Contributor Author

RFDarter commented Feb 17, 2024

ghcr.io/esphome/aioesphomeapi-proto-builder

running
docker run -v "$PWD":/aioesphome ghcr.io/esphome/aioesphomeapi-proto-builder:latest
results in
docker: invalid reference format.

running
docker run -v C:\Users\rfdarter\Documents\Git\aioesphomeapi:/aioesphome ghcr.io/esphome/aioesphomeapi-proto-builder:latest
instead runs the docker but results in this error
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "script/gen-protoc": stat script/gen-protoc: no such file or directory: unknown.

I installed protoc and ran
py script\gen-protoc
is that fine too? Should i commit the generated C files?

@bdraco
Copy link
Member

bdraco commented Feb 17, 2024

Here is what I get

bdraco@MacBook-Pro aioesphomeapi % docker run -v "$PWD":/aioesphomeapi ghcr.io/esphome/aioesphomeapi-proto-builder:latest
bdraco@MacBook-Pro aioesphomeapi % 

@bdraco
Copy link
Member

bdraco commented Feb 17, 2024

We need to use the version in the docker container so we don't introduce a generated protobuf code version change as well. I went ahead and ran it locally and fixed the lint issues

@bdraco
Copy link
Member

bdraco commented Feb 18, 2024

I made some breaking changes in api v22 so I adjusted your PR for them

@jesserockz jesserockz merged commit f8ee918 into esphome:main Mar 7, 2024
10 checks passed
@jesserockz jesserockz changed the title Implement Datetime component Implement Datetime date component Mar 7, 2024
@jesserockz jesserockz changed the title Implement Datetime date component Implement Datetime date entity Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor waiting-for-esphome Indicates the PR is waiting for the esphome main repo code approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants