-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Datetime date entity #824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2438 2449 +11
=========================================
+ Hits 2438 2449 +11 ☔ View full report in Codecov by Sentry. |
Please generate the protobuf files with
|
running running I installed protoc and ran |
Here is what I get
|
We need to use the version in the docker container so we don't introduce a generated protobuf code version change as well. I went ahead and ran it locally and fixed the lint issues |
Co-authored-by: J. Nick Koston <[email protected]>
I made some breaking changes in api v22 so I adjusted your PR for them |
Implements the Datetime component from this PR
Related PRs: