Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valve component #852

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Add valve component #852

merged 3 commits into from
Apr 17, 2024

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Mar 29, 2024

Adds support for valve components/entities

@kbx81 kbx81 mentioned this pull request Mar 29, 2024
13 tasks
@kbx81 kbx81 force-pushed the add-valve-support branch from 7b1e7ba to 345674b Compare March 29, 2024 03:31
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7da8a35) to head (1be6fd7).
Report is 12 commits behind head on main.

❗ Current head 1be6fd7 differs from pull request most recent head 1be4ecf. Consider uploading reports for the commit 1be4ecf to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #852   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2463      2489   +26     
=========================================
+ Hits          2463      2489   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the below message IDs to not conflict with previous messages and the open Event Entity PR =)

@kbx81 kbx81 marked this pull request as ready for review April 10, 2024 01:48
@jesserockz jesserockz merged commit 0ed69bb into esphome:main Apr 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants