Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add modexp overflow test #1096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamWilsn
Copy link
Contributor

πŸ—’οΈ Description

Tests the case where a large base1 is added to 96. Both Geth and Nethermind correctly revert the precompile call with an out-of-gas error, but EELS crashes with an OverflowError.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Footnotes

  1. 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffa0 ↩

Tests the case where a large base[^1] is added to 96. Both Geth and
Nethermind correctly revert the precompile call with an out-of-gas
error, but EELS crashes with an `OverflowError`.

[^1]: `0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffa0`

Reported-by: Omik
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The CI failure is expected since the issue is still in the EELS version in:

"commit": "9b95554a88d2a8485f8180254d0f6a493a593fda"

ref: 9b95554a88d2a8485f8180254d0f6a493a593fda

ref: 9b95554a88d2a8485f8180254d0f6a493a593fda

I think we can include changes to all these references in this same PR.

Also we might need to rebase devnets/prague/5 branch on top of the fix, otherwise filling tests for the devnet release is going to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants