Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Add transactions root calculation #353

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 6, 2023

🗒️ Description

Adds transactions root calculation in blockchain tests, instead of using the one returned by t8n, since it omits the invalid transactions included in the block (which is the correct behavior when producing state tests).

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tools Scope: Changes ethereum_test_tools package type:chore Type: Chore labels Dec 6, 2023
@marioevz marioevz force-pushed the add-txs-root-calc branch 2 times, most recently from 2c82fc6 to 32274c2 Compare January 4, 2024 22:42
@marioevz marioevz requested a review from danceratopz January 5, 2024 14:51
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@marioevz marioevz merged commit 7306261 into ethereum:main Jan 5, 2024
5 checks passed
@marioevz marioevz deleted the add-txs-root-calc branch January 5, 2024 19:31
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tools Scope: Changes ethereum_test_tools package type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants