simulators/ethereum/engine: remove terminal total difficulty #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should close #1185 right? |
|
Yes! |
|
There are a couple broken tests though, I don't understand all the tests enough to know how to fix them. One type of test that still uses a chain with a PoW prefix is the sync test. I would vote for removing the sync tests in ethereum/engine simulator, and leave them for the ethereum/sync simulator. It uses a cancun-based chain at the moment. |
marioevz
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the merge has long passed, and clients are starting to remove support for the merge transition, we can update the engine API tests to start at genesis.