chore(#624): change config parameters to use for redirect url #625
Conversation
Ike Plugins (test-keeper)Thank you @dipak-pawar for this contribution!
It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin. |
|
@dipak-pawar snapshot fabric8-auth image is available for testing. |
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 84 84
Lines 8485 8485
=======================================
Hits 6177 6177
Misses 1835 1835
Partials 473 473Continue to review full report at Codecov.
|
| @@ -75,6 +75,11 @@ objects: | |||
| configMapKeyRef: | |||
| name: ${SERVICE_NAME} | |||
| key: notification.serviceurl | |||
| - name: AUTH_UI_URL | |||
There was a problem hiding this comment.
if we really need such a URL configured in auth (which I'm not really a fan of), then we'll also have to declare it in https://github.com/fabric8-services/fabric8-auth/blob/master/openshift/auth.app.yaml#L31
| @@ -33,3 +33,5 @@ objects: | |||
| data: | |||
| wit.url: http://wit | |||
| notification.serviceurl: http://f8notification | |||
| # you can set "ui.url" to your locally deployed ui. by default it's localhost:8080 | |||
| # ui.url: http://ui | |||
There was a problem hiding this comment.
I assume there's a variable with the default value set to localhost:8080 declared in https://github.com/fabric8-services/fabric8-auth/blob/master/configuration/configuration.go ?
| @@ -50,7 +50,7 @@ objects: | |||
| notapproved_redirect: "" | |||
| keycloak.url: https://sso.openshift.io | |||
| notification.serviceurl: "" | |||
| email.verify.url: https://prod-preview.openshift.io/_home | |||
| invitation.accepted.url: https://prod-preview.openshift.io/_home | |||
| email.verify.url: https://openshift.io/_redirects/_verifyEmail | |||
There was a problem hiding this comment.
AFAIK, this file is just an example. If there's something to fix on prod and pre-prod, we'll have to open a HK to update the configmaps
|
These should only be the defaults. |
|
@dipak-pawar Should we close this? |
|
@dipak-pawar snapshot fabric8-auth image is available for testing. |
Fixes: #624