Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update “System requirements” section to clarify supported operating systems #984

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

sonicdoe
Copy link
Contributor

@sonicdoe sonicdoe commented Oct 1, 2020

Since #946, fastlane officially supports macOS, Linux, and Windows. The System requirements section still mentions only macOS and links to the already-closed fastlane/fastlane#11687. Therefore, this section can arguably be removed altogether.

@rogerluan
Copy link
Member

rogerluan commented Mar 7, 2021

Not sure if we really "support" non-macOS platforms. I know fastlane eventually works with some of them, there's certain degree of cross-platform compatibility, but I'm uncertain about "official support".

I think @janpio and @joshdholtz will know more about this 🙏

Also, this is related: #750

@rogerluan rogerluan requested review from janpio and joshdholtz March 7, 2021 06:11
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 This section is highly out of date 😱 Instead of removing, I think I would like to still clarify that fastlane is fully supported on mac and that linux and windows are partially supported. I left a sample of what I think should be added 😊 Let me know your thoughts on this!

Thanks ❤️

docs/index.md Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@rogerluan rogerluan changed the title Remove “System requirements” section update “System requirements” section to clarify supported operating systems Mar 23, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@joshdholtz joshdholtz merged commit 87fcb77 into fastlane:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-macOS platform support (Windows + Linux)
4 participants