extend ulyssa/shielding-stubs by removing the Unsupported error, and returning _something_.
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewiscowper
commented
Jan 17, 2025
|
|
||
| let mut shield_config = name.split('-'); | ||
|
|
||
| let first = shield_config.next().expect("first is required"); |
There was a problem hiding this comment.
I leave it up to your discretion to rename these as makes sense, I'm not 100% sure what the blocks refer to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for calls that use the shielding APIs, as they are, not to crash. I've no idea how correct, useful, or otherwise relevant the output is, but I went from my tests failing to passing after making these adjustments locally.