feat: provide log-detective explain integration for failed builds #3608
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1225,7 +1225,7 @@ | |||
| path = os.path.normpath(os.path.join(*path_parts)) | |||
| return urljoin(app.config["BACKEND_BASE_URL"], path) | |||
|
|
|||
| def _compressed_log_variant(self, basename, states_raw_log): | |||
| def log_variant(self, basename, states_raw_log): | |||
Check warning
Code scanning / vcs-diff-lint
Build.log_variant: Missing function or method docstring Warning
nikromen
force-pushed
the
log-detective-integration
branch
from
d51316c to
b9793b7
Compare
| <a href="{{ failed_build_log_url | format(url) }}" class="btn btn-default btn-xs"> | ||
| <span class="pficon pficon-info"></span> Explain with Log Detective AI | ||
| </a> | ||
| {% endif %} |
There was a problem hiding this comment.
Can we place this into a separate column, since this is not a log file but "request for explanation".
There was a problem hiding this comment.
Or, maybe we could have a clickable "failed" state? Can you upload a screenshot?
| @@ -157,6 +157,12 @@ | |||
| <span class="pficon pficon-ok"></span> {{ state }} | |||
| {% elif state == "failed" %} | |||
| <span class="pficon pficon-error-circle-o"></span> {{ state }} | |||
| {% if failed_build_log_url and config.LOG_DETECTIVE_BUTTON %} | |||
There was a problem hiding this comment.
The used config option is ON in prod, and we want to keep this new UI disabled for some time... I think we need yet another option.
There was a problem hiding this comment.
Maybe not, it will be quite some time before we'll do a new Copr release anyway.
|
|
||
| Returns: | ||
| the full URL to the log file or None if the log file does not exist | ||
| """ |
There was a problem hiding this comment.
🤷 this rewrite is weird, can we have a separate method for the new link?
There was a problem hiding this comment.
Or IMHO even better, can we improve log detective to handle the compressed logs?
very wip
Merge after fedora-copr/logdetective-website#207