[Fil-480] Add validation to add storage providers input #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
force-pushed
the
FIL-480-add-validation-to-add-storage-providers-input
branch
from
eca690c to
911a787
Compare
kacperzuk-neti
approved these changes
Dec 10, 2024
Comment on lines
+106
to
+108
| } else if (!isValidInput(value)) { | ||
| updatedErrors[index] = 'Invalid storage provider id' | ||
| setErrors([...updatedErrors]) |
There was a problem hiding this comment.
@tplocic20 what do you think about DYI form validation and debouncing? Is this the best way given the state of the app or is there some good lightweight lib we could include?
There was a problem hiding this comment.
Ideally we would use something like hookForm - but it's too much of a refactor I'm afraid
tplocic20
approved these changes
Dec 13, 2024
Filip-L
deleted the
FIL-480-add-validation-to-add-storage-providers-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.