Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix comments in .go #12870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

comfsrt
Copy link

@comfsrt comfsrt commented Feb 4, 2025

api/api_full.go
incosistency - inconsistency

api/api_storage.go
onde r- under

@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Feb 4, 2025
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but please run make gen on top of this, both of these godocs get compiled into openrpc docs that get checked in as well

@comfsrt
Copy link
Author

comfsrt commented Feb 5, 2025

sorry , I'm running into build issues on macOS with filecoin-ffi (pkg-config/hwloc/filcrypto.pc) and can't successfully run make gen.
Could you please generate the files yourself , or give me some guidance on how to configure the environment?

Thanks

@comfsrt comfsrt requested a review from rvagg February 5, 2025 08:26
@rvagg
Copy link
Member

rvagg commented Feb 6, 2025

Interesting, I didn't think make gen got far enough into it to need all the ffi stuff, can you provide your error output? this might be something we can address to make it easier.
Also, the README points you to https://lotus.filecoin.io/lotus/install/macos/ where you can find some simple brew instructions to install pkg-info, hwloc and friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ⌨️ In Progress
Development

Successfully merging this pull request may close these issues.

3 participants