Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #32

Open
erikras opened this issue Mar 4, 2019 · 3 comments
Open

Tests #32

erikras opened this issue Mar 4, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@erikras
Copy link
Member

erikras commented Mar 4, 2019

Does anyone have experience in writing tests with hooks? There should be no need to test the part that Final Form does (e.g. does a field become dirty when the value changes), but we need something in place to evaluate new features as they get added, and to ensure that a PR doesn't break the whole library.

Maybe something along these lines?

If anyone would like to give this a shot, it would be greatly appreciated! 🙏
@erikras erikras added enhancement New feature or request help wanted Extra attention is needed labels Mar 4, 2019
@jprask
Copy link
Contributor

jprask commented Apr 12, 2019

@erikras I have a little bit of experience with it, they moved the hooks testing to it's own lib and i think that's what people are using. I'm down to set it up and write a few tests so we can discuss it on a PR 👌

@erikras
Copy link
Member Author

erikras commented Apr 12, 2019

Great!

@jprask jprask mentioned this issue Apr 18, 2019
Merged
@renatoagds
Copy link

@erikras Any reason to this still open? That's something more to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@renatoagds @erikras @jprask