Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add tests #40

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Feature/add tests #40

merged 5 commits into from
Apr 30, 2019

Conversation

jprask
Copy link
Contributor

@jprask jprask commented Apr 18, 2019

Description

This PR adds some tests for the hooks in the repo. We are using react-hooks-testing-library for it. Some simple test scripts were added to package-scripts, let me know if something fancier is needed. I also removed the test configuration from .babelrc because jest was throwing a “Duplicate plugin/preset detected.” error.

image

Solves #32

@erikras
Copy link
Member

erikras commented Apr 30, 2019

Looks good!

@erikras erikras merged commit 7a7d03a into final-form:master Apr 30, 2019
@erikras
Copy link
Member

erikras commented May 1, 2019

Published in v2.0.0.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants