Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use shadow-rs for build info #891

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Dec 23, 2023

closes #890

@orhun orhun requested a review from zicklag December 23, 2023 13:09
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VERSION constant was apparently displaying multiple versions in like a YAML format, and also needed to be tweaked to return a &str so egui knows not to make it look like an editable textbox. I also needed to remove the default features in the non-build dependency so that it would build on WASM, but now everything looks good!

I also tested locally to make sure you could build with just a source snapshot and no git repository.

@zicklag zicklag added this pull request to the merge queue Dec 23, 2023
Merged via the queue into fishfolk:main with commit f1f0538 Dec 23, 2023
8 checks passed
@zicklag
Copy link
Member

zicklag commented Dec 23, 2023

Published v0.9.3 with this update.

@orhun
Copy link
Member Author

orhun commented Dec 23, 2023

That's great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow compilation without git binary
2 participants