Expose weak_tombstone/weak_remove
#126
Open
+345
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing locally I'm not seeing the change in folder growth for them (with temporary false), that I'm seeing in my similar project.
marvin-j97
reviewed
Jan 14, 2025
I need to remember to run it before committing in this repo. Local `cargo clippy` has no errors, hoping CI clippy is also clear.
Must be stable vs the msrv toolchain I'm using locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This naively exposes
weak_tombstone/weak_removefromlsm-tree.I tested locally with my project and saw that disk usage was no longer growing infinitely. I tried to write some tests for it, but I'm not sure how to force a flush and/or get information about tombstones out of the testable interfaces.
Benching it has the same write performance, but I'd assume the difference would be in other stages. The doc could be considered placeholder, they're paraphrasing the rockdb SingleDelete info, after looking at the
CompactionStreaminlsm-tree.This exposes a fix for #115 via #56