Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: merge PlaceOrder and SpotTrade; fix #145 #152

Merged
merged 6 commits into from
May 5, 2021

Conversation

lispc
Copy link
Member

@lispc lispc commented Apr 29, 2021

This is a very big commit...

  1. merge PlaceOrder with SpotTrade. So we no longer need a separate PlaceOrder L2 tx. It is very helpful for the real tps.
  2. feature: implement strategy of overwrite order tree in state_manager #104 and feature: implement strategy of overwrite order tree in circuit #105 code complete. I will write tests later.

TODOs for circuits:

  1. reuse UniversalChecker for Transfer / Withdraw / SpotTrade
  2. test feature: implement strategy of overwrite order tree in state_manager #104 and feature: implement strategy of overwrite order tree in circuit #105
  3. fix related Rust code
  4. fix test/massive.ts

@lispc lispc changed the title WIP feature: merge PlaceOrder and SpotTrade; fix #145 feature: merge PlaceOrder and SpotTrade; fix #145 May 5, 2021
@lispc lispc merged commit ec63741 into master May 5, 2021
@lispc lispc deleted the feat/zzhang/merge_order_and_trade branch May 5, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant