[web] Reland: (Add crossOrigin property to <img> tag used for decoding)++
#57228
+71
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hotfix this in stable. |
mdebbar
added
the
autosubmit
|
Failed to create CP due to merge conflicts. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2024
…ed for decoding)++ (flutter/engine#57228)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2024
…160450) flutter/engine@8535ce3...6a75cb6 2024-12-17 [email protected] [web] Reland: (Add `crossOrigin` property to `<img>` tag used for decoding)++ (flutter/engine#57228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…oding)++ (flutter/engine#57228) Relands flutter/engine#54961 with a few more changes and tests. Fixes flutter#160127
|
Has the cherry-pick request been created yet? |
|
@Reprevise I submitted #160819 but I haven't received a reaction on it yet and not sure I did it correctly (as it's the first time I submit a CP request). |
|
Maybe @yjbanov can take a look? |
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…ed for decoding (#57272) Original PR: #57228 @christopherfujino Approved for hotfix to stable by @yjbanov in #57228 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #54961 with a few more changes and tests.
Fixes flutter/flutter#160127