-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player_platform_interface] Platform view support #8453
base: main
Are you sure you want to change the base?
[video_player_platform_interface] Platform view support #8453
Conversation
@stuartmorgan This PR changes the perception a little bit - we now should use player ID in app-facing package, and have no knowledge about texture ID there. How should I go about renaming What would be best way to rename it in all packages without breaking the static analysis in the meantime? What kind of changes should I add to this PR? Rename it in platform interface? Rename it everywhere? We're currently in an ugly state where we allow using platform views, but we still use |
I think the best way to do this is probably:
In order to pass CI you'll need to add |
cb0c669
to
04973c2
Compare
af483a1
to
118447c
Compare
@stuartmorgan As suggested, in this PR I renamed parameters in the platform interface and added ignores to the package implementations. The checks on the CI now fail, but I assume that this could be resolved with |
This PR is a subset of #8237 - it only adds platform interface changes.
Partially resolves 86613.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.