Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectmenu button should be inline-block #166

Merged
merged 1 commit into from
Jan 18, 2012
Merged

Conversation

betalb
Copy link

@betalb betalb commented Sep 23, 2011

After setting wrapperElement to

by default selectmenu became block-level element.

Default browser select box is inline-block

Here is sample fiddle http://jsfiddle.net/nwFMs/

@fnagel
Copy link
Owner

fnagel commented Oct 10, 2011

I will take a look as soon as v1.2 is released. Thanks for your contribution!

Closed, related issue: #158

@fnagel
Copy link
Owner

fnagel commented Nov 24, 2011

Sorry for the delay. This issue is not forgotten...

@betalb
Copy link
Author

betalb commented Nov 24, 2011

I just thought, that separation wrappers for button/menu is not the best way. Maybe just drop wrapper for button. It seems that to fix IE6 issue only menu wrapper is needed

@fnagel
Copy link
Owner

fnagel commented Nov 24, 2011

Thats correct but to use a CSS scope (needed for themeswitcher) a wrapping div is needed for the button as well.

Im thinking of removing that option (but not the wrapper) completely as its not needed. We could do that like in the new, built from scratch version of selectmenu: http://view.jqueryui.com/selectmenu/demos/selectmenu/default.html
See #140 for more information.

We would add and use the widget method to get both, menu and button and add a CSS class. See withOverflow example in above posted demo.

@fnagel
Copy link
Owner

fnagel commented Dec 23, 2011

I forgot to mention that, in accordance to the new selectmenu version, I will change the button wrapper from div to span, so it will be inline style.

fnagel added a commit that referenced this pull request Jan 18, 2012
fixed: make button span so its inline element
@fnagel fnagel merged commit 7dd8c08 into fnagel:selectmenu Jan 18, 2012
@fnagel
Copy link
Owner

fnagel commented Jan 18, 2012

Please note I removed this option completely to make it more compatible to the new version (see #140).
See this commit: 7021f15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants