fix(lspconfig): add hook before and not after #92
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig` functions rely on final `settings` values
|
This PR is stale because it has been open 30 days with no activity. |
|
Any chance for a review on this? |
|
This PR is stale because it has been open 30 days with no activity. |
|
Any chance for a review on this? |
|
This PR is stale because it has been open 30 days with no activity. |
|
This isn't stale! Still waiting for review and keeping up to date :) |
|
This PR is stale because it has been open 30 days with no activity. |
|
This isn't stale, still ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A common use of
on_new_configis to construct thecmdfor starting language servers based on the configuration. These language servers require that the settings are finalized before it is run. It looks like previous commits did useadd_hook_beforefor thelspconfigintegration but it got moved to beingadd_hook_afterwhen centralizing it with thelua_lsandjsonlsplugin integrations. We should revert this back toadd_hook_beforeso that the existingon_new_configfunctions continue working.