Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax highlighting colors #3017

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update syntax highlighting colors #3017

wants to merge 2 commits into from

Conversation

savq
Copy link
Contributor

@savq savq commented Sep 10, 2024

  • Replace --cm-color-[atom|property] with --cm-color-symbol.
    Use a bolder typeface for properties.
  • Replace --cm-color-number with --cm-color-literal.
    Highlight booleans, characters, and numbers as literal.
  • Rename --cm-color-var to -variable.

  • Update light theme "main" colors
  • Update dark theme "main" colors
  • Update light theme mixed parser colors
  • Update dark theme mixed parser colors

Closes #2921

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/savq/Pluto.jl", rev="theme")
julia> using Pluto

savq added 2 commits January 19, 2025 02:00
- Replace `--cm-color-[atom|property]` with `--cm-color-symbol`.
  Use a bolder typeface for properties.

- Replace `--cm-color-number` with `--cm-color-literal`.
  Highlight booleans, characters, and numbers as literal.

- Rename `--cm-color-var` to `--cm-color-variable`
--cm-color-literal: #8e5189;
--cm-filter-type: brightness(150%) saturate(50%);;

/* The colors below are not used in CellInput.js */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this comment? if they are not used then why have them?

@fonsp fonsp added frontend Concerning the HTML editor CM6 CodeMirror 6 labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CM6 CodeMirror 6 frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve contrast of code highlighting
2 participants