Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: can handle bigint data #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: can handle bigint data #186

wants to merge 1 commit into from

Conversation

kesoji
Copy link

@kesoji kesoji commented Feb 1, 2025 •
edited
Loading

Description

Fixes #185

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I added returning bigint code in test-apps and check loader and action can handle bigint.

I want to add unit tests but can't figure out appropriate position to place tests.

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • [ x I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loader returning BigInt breaks dev server
1 participant
@kesoji