Replace deprecated SASS methods #2100
Open
+63
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@aleho thank you for addressing the deprecations and submitting this. Could you please update the settings file to resolve the other deprecations there?
@joeworkman if this will get updated, would you accept this change and cut a release? It would help to further reduce the Dart Sass deprecations.
*) map-get *) floor, percentage *) lighten, darken, scale-color
|
@javierjulio Is there anything else to do on this PR? |
|
@aleho no, not that I know of. Sorry, I'm not a maintainer. This depends on @joeworkman approving and merging. There is another set of PRs for foundation-sites to resolve SASS deprecations that are all ready for review. |
|
@javierjulio Sorry, my bad! I assumed because you reviewed it you'd be able to merge. Thank you anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, compiling with SASS 1.79, some color functions now output deprecation warnings.
This PR keeps the legacy behavior as documented at e.g., https://sass-lang.com/documentation/modules/color/#darken.