Cast default RPC providers #2855
Open
+558
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
force-pushed
the
2708-cast-default-urs
branch
from
9429b14 to
820a442
Compare
cptartur
force-pushed
the
2708-cast-default-urs
branch
from
820a442 to
9fe7ffb
Compare
cptartur
force-pushed
the
2708-cast-default-urs
branch
from
9fe7ffb to
1300d99
Compare
cptartur
requested review from
ddoktorski,
kkawula and
franciszekjob
as code owners
kkawula
reviewed
Jan 16, 2025
franciszekjob
requested changes
Jan 16, 2025
kkawula
reviewed
Jan 16, 2025
crates/sncast/src/helpers/rpc.rs
Outdated
| FreeProvider::Blast => { | ||
| "https://starknet-mainnet.public.blastapi.io/rpc/v0_7".to_string() | ||
| } | ||
| FreeProvider::Voyager => "https://free-rpc.nethermind.io/mainnet-juno".to_string(), |
There was a problem hiding this comment.
Probably version should be added here as well
There was a problem hiding this comment.
kkawula
reviewed
Jan 16, 2025
kkawula
reviewed
Jan 16, 2025
kkawula
reviewed
Jan 16, 2025
| @@ -44,7 +44,7 @@ pub struct Create { | |||
| pub salt: Option<Felt>, | |||
|
|
|||
| /// If passed, a profile with provided name and corresponding data will be created in snfoundry.toml | |||
| #[clap(long)] | |||
| #[clap(long, conflicts_with = "network")] | |||
There was a problem hiding this comment.
adding profile should be possible if the account is created using network alias
There was a problem hiding this comment.
The profile stores the provider url in the Scarb.toml. If we allow this, we'll be adding URL of the free providers to users' Scarb.toml files which I though is not ideal.
kkawula
reviewed
Jan 16, 2025
Co-authored-by: Franciszek Job <[email protected]> Co-authored-by: kkawula <[email protected]>
Co-authored-by: Franciszek Job <[email protected]>
…-cast-default-urs
franciszekjob
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2708
Introduced changes
sncastunder--networkflag--networkflag to--network-nameinsncast account deleteandsncast account importdue to conflict with the added flagChecklist
CHANGELOG.md