Skip to content

Commit

Permalink
OSVERSION: relax requirement
Browse files Browse the repository at this point in the history
While we want to advocate for OSVERSION requirement, relax it a bit to
not break uses cases like populating a rootdir.

If OSVERSION is provided, guess it from the ABI string and loudly show
it to warn the user but proceceed anyway
  • Loading branch information
bapt committed Jan 23, 2025
1 parent 3d4ad76 commit 07b0dd8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions libpkg/pkg_config.c
Original file line number Diff line number Diff line change
Expand Up @@ -1046,8 +1046,9 @@ config_init_abi(struct pkg_abi *abi)

if (abi->os == PKG_OS_FREEBSD) {
if (env_osversion_string == NULL) {
pkg_emit_error("Setting ABI requires setting OSVERSION as well");
return (false);
pkg_emit_error("Setting ABI requires setting OSVERSION, guessing the OSVERSION as: %d",
pkg_abi_get_freebsd_osversion(abi));
return (true);
}

const char *errstr = NULL;
Expand Down

0 comments on commit 07b0dd8

Please sign in to comment.