-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Fix 1633 unexpected key error with primary key in schema #1640
Closed
amelie-rondot
wants to merge
20
commits into
frictionlessdata:main
from
amelie-rondot:Fix-1633-Unexpected-key-error-with-primary-key-in-schema
Closed
WIP : Fix 1633 unexpected key error with primary key in schema #1640
amelie-rondot
wants to merge
20
commits into
frictionlessdata:main
from
amelie-rondot:Fix-1633-Unexpected-key-error-with-primary-key-in-schema
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a required field and primary key schema: test fails
…onding to a primary key schema: test fails
… primary key schema field: test passes
…mary key schema: test fails
…l error when missing label corresponding to a schema primary key: test fails
…imary key constraint and considering case-sensitivity
…ary key label to the schema fields
This PR is replaced by PR#1641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix unexpected KeyError raised when a primary key used in shema is missing in the tabular data to validate.
For example:
This PR adds some test cases:
NB: to deal with insensitivity case, this PR should be rebased the branch related to this PR
Through this PR, I also suggest a refactoring to introduce intermediary
TableResource
methods to createcells
related to primary key schema.