Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullstory_event_types -> fullstory_events_types #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sabrina-li
Copy link

@sabrina-li sabrina-li commented Dec 11, 2024

fullstory_event_types doesn't work, looks like it should be fullstory_events_types (with an s) as used in the sql files

@huttotw
Copy link
Contributor

huttotw commented Dec 11, 2024

@sabrina-li thanks for this fix, I think the docs actually read better, can we change the SQL to use fullstory_event_types? We'll release a new version after this is merged!

@sabrina-li
Copy link
Author

@sabrina-li thanks for this fix, I think the docs actually read better, can we change the SQL to use fullstory_event_types? We'll release a new version after this is merged!

I wonder if it makes sense to support both in code, and note a deprecation in README? Since it's a breaking change.
Was thinking we could eventually drop the support when bumping the major version when bigger changes are at play? WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants