Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace background image (grpc-bg.svg) with a simple gradient #317

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

dragonsinth
Copy link
Member

@dragonsinth dragonsinth commented Apr 27, 2024

#316

The background image (grpc-bg.svg) is significantly large in size (1.7MB). When embedded into servers with limited bandwidth, it consumes a significant portion of the available resources and results in slower load times.

Please consider replacing the existing image with a simpler pattern or opt for a plain color background.

Before:

Screenshot 2024-04-27 at 11 29 56 AM

After:

Screenshot 2024-04-27 at 11 31 33 AM

Any feedback on the exact color choices is welcome.
CC: @lqs

@dragonsinth
Copy link
Member Author

CC: @jhump what was the story on that SVG anyway?

@dragonsinth dragonsinth merged commit a84a94c into master Apr 29, 2024
6 checks passed
@dragonsinth dragonsinth deleted the nosvg branch April 29, 2024 13:30
@jhump
Copy link
Contributor

jhump commented Apr 29, 2024

A little surprising that it is so large... I just lifted it from the grpc.io home page (which still uses it today). I didn't think too much about it beyond that. My bad.

@dragonsinth
Copy link
Member Author

A little surprising that it is so large... I just lifted it from the grpc.io home page (which still uses it today). I didn't think too much about it beyond that. My bad.

No big deal, I'm surprised anyone ever noticed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants