Camera visual fov fix #3307

InigoMoreno · 2023-03-17T14:59:42Z

🦟 Bug fix

Fixes #3306 by changing the dist variable. I could have also changed the width, but it could create very big images for wide angle cameras.

I did it in gazebo9, as it's the version I was testing, but it should also work on gazebo11. If someone could point me to the file where CameraVisual is in the newer versions of gazebo, looked at gz-rendering, but it doesn't seem to be any CameraVisual there.

Summary

Run the world mentioned on the issue before and after the PR.

Checklist

Signed all commits for DCO
Added tests
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Remove X11 call from Gazebo 7 Approved-by: Steve Peters <[email protected]> Approved-by: Ian Chen <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

…#2769) * Fixed crash when collision size is zero Signed-off-by: ahcorde <[email protected]> * Using ignition::math::isnan Signed-off-by: ahcorde <[email protected]> * Improved error message Signed-off-by: ahcorde <[email protected]> * fixed method to get the name of the visual Signed-off-by: ahcorde <[email protected]> * Fixed else brackets Signed-off-by: ahcorde <[email protected]> * [Gazebo 9] Added test to check collisions equal to zero (gazebosim#2788) * Added test to check collisions equal to zero Signed-off-by: ahcorde <[email protected]> * Included feedback Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Update Visual_TEST.cc

Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

Backport lockstep changes to gazebo9

Signed-off-by: Louise Poubel <[email protected]>

* add publisher private class to hold OnPublishComplete callback Signed-off-by: Ian Chen <[email protected]> * std bind and rearrage pub node fini Signed-off-by: Ian Chen <[email protected]> * add comment on PublisherPrivate Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

…ers (gazebosim#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>

Signed-off-by: ahcorde <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

…<p> (gazebosim#2825) * add test to check gazebo model generated by assimp4, see gazebosim#2682 * Length of polylist <p> is not the number of inputs (i.e. VERTEX and NORMAL) * vcount.size() * 3. If both VERTEX and NORMAL have offset 0, then the length of polylist <p> is vcount.size() * 3. So use length of set(offset) as inputSize. This fix for cases where VERTEX and NORMAL share same vcounts, see gazebosim#2682 (comment) Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]>

…m#2779) When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is also needed for pkg-config files.

gazebosim#2833) Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: ahcorde <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Signed-off-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Steve Peters <[email protected]>

* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>

…im#2988) * Add nullptr guard in TopicManager PubToSub * Add regression test for 2875 * Port API to gazebo9 Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

…im#2991) * Add error message to RT shader * Improve error message for loading worlds/empty.world Signed-off-by: Audrow Nash <[email protected]>

… the same name (Gazebo9) (gazebosim#3016) * Initial implementation of SDF checking feature Co-authored-by: Jenn Nguyen <[email protected]>

* Update version * Update Changelog

…gazebosim#3039) (gazebosim#3053) * Fixed ApplyWrenchDialog to properly handle nested models. * Fix improper link being selected when opening applywrenchdialog * Fixed styling issues * Test nested models in ApplyWrenchDialog + update test world * Separate nested_multilink world to avoid breaking ModelListWidget test * Fix incorrect comment * More styling fixes * Fix link name parsing to support sdformat<11 Co-authored-by: Cameron Miller <[email protected]>

…#3031) * get ids recursively * make namespacing of ~/model/modify, ~/model/info, and server-side name setting on modify consistent * add tests for included and nested models * get scoped name by stripping parent name * move test models, add strip name test, style changes Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>

* IncrementalPlot.cc: include qwt_scale_map.h * Use Qt::MiddleButton to fix deprecation warning * PlotCurve: add private helper for renamed members In qwt 6.2, they have renamed all member variables, so create helper functions to minimize the ifdefs we will need to support both versions. * PlotCurve: add ifdefs to support qwt 6.2.0 Signed-off-by: Steven Peters <[email protected]>

We currently don't support 2021 and newer, see gazebosim#2867. Signed-off-by: Steven Peters <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

- Initial connection (insert) and cleanup (remove) locked with mutex - Signal (access) checks for object not null before attempting to access (not locking because would need recursive mutex) - Declare mutex as mutable so EventCount const method can block it - Include race condition test to play with connections inside an event (contribution by Sonia Jin from AWS, back port of gazebosim#3042) Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: sonia <[email protected]>

Backport gazebosim#3031 - Make links within nested models modifiable from GUI Client

Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Steve Peters <[email protected]>

Signed-off-by: Martin Pecka <[email protected]> Co-authored-by: Louise Poubel <[email protected]>

…gazebosim#3278) * Use find_package(Python3) with newer cmake Signed-off-by: Steve Peters <[email protected]>

talregev · 2023-10-17T19:47:50Z

@InigoMoreno Can you rebase to the latest gazebo11 dev?

traversaro · 2024-01-08T11:48:20Z

@InigoMoreno it seems that there are a lot of conflicts in the PR.

chapulina and others added 30 commits February 20, 2020 19:34

Remove X11 call from Gazebo 7

7d10842

Close branch remove_x11

13c1e01

Merged in remove_x11 (pull request gazebosim#3195)

ef4a8b1

Remove X11 call from Gazebo 7 Approved-by: Steve Peters <[email protected]> Approved-by: Ian Chen <[email protected]>

[gazebo7] Update BitBucket links (gazebosim#2715)

a07d57f

Signed-off-by: Louise Poubel <[email protected]>

backport lockstep changes to gz9

bbc6498

Signed-off-by: Ian Chen <[email protected]>

add sensor extension class as workaround to preserve ABI compatibility

825b193

Signed-off-by: Ian Chen <[email protected]>

fix image sensor container abi

f72befc

Signed-off-by: Ian Chen <[email protected]>

port tests

137fd96

Signed-off-by: Ian Chen <[email protected]>

add test world src files

dc2f7dd

Signed-off-by: Ian Chen <[email protected]>

test removing type

bd38258

Signed-off-by: Ian Chen <[email protected]>

remove unused param

95855f8

Signed-off-by: Ian Chen <[email protected]>

⬆️ 7.16.1

de8980d

Signed-off-by: Louise Poubel <[email protected]>

7 ➡️ 9

b0f42d4

Signed-off-by: Louise Poubel <[email protected]>

backport camera strict test world fix

a479501

Signed-off-by: Ian Chen <[email protected]>

Merge pull request gazebosim#2793 from osrf/respect_fps_gz9

cca6528

Backport lockstep changes to gazebo9

revert change

bf171c4

Signed-off-by: Louise Poubel <[email protected]>

7 ➡️ 9 (gazebosim#2801)

11ebf3d

Signed-off-by: Louise Poubel <[email protected]>

⬆️ 9.14.0 (gazebosim#2815)

21db7f2

Signed-off-by: Louise Poubel <[email protected]>

[Gazebo9] More enhancement for Windows build (gazebosim#2789)

af30f74

Port Ignition Common's profiler to Gazebo 9 (gazebosim#2813)

be44390

Signed-off-by: ahcorde <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

Fix assumptions that CMAKE_INSTALL_*DIR paths are relative. (gazebosi…

3a848db

…m#2779) When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is also needed for pkg-config files.

use true unlit black (zero) values for objects without reflectance map (

2f3024d

gazebosim#2833) Signed-off-by: Ian Chen <[email protected]>

remove lighting param (gazebosim#2840)

85f8332

Signed-off-by: Ian Chen <[email protected]>

[Gazebo 9] Publish performance metrics (gazebosim#2819)

7adba90

Signed-off-by: ahcorde <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>

Improve transport::Publisher reliability (gazebosim#2725)

c8bf695

Signed-off-by: Louise Poubel <[email protected]>

⬆️ 9.15.0 (gazebosim#2850)

fededa7

Signed-off-by: Louise Poubel <[email protected]>

scpeters and others added 24 commits April 19, 2021 16:43

LensFlare: rename SetCameraSensor to SetCameraImpl (gazebosim#2975)

c467d7f

This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <[email protected]>

Protect DepthCameraPlugin globals with a mutex (gazebosim#2949)

bf3ffb4

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Avoid deadlock in ConnectionManager::Stop (gazebosim#2950)

a5201c7

Signed-off-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Steve Peters <[email protected]>

Fix ogre_log test (gazebosim#2954)

e9c4101

* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <[email protected]>

Bump to 9.17.0 and update changelog (gazebosim#2980)

7d34e91

Signed-off-by: Steve Peters <[email protected]>

Check for nullptr in TopicManager::ConnectPubToSub (gazebo9) (gazebos…

b5f09f2

…im#2988) * Add nullptr guard in TopicManager PubToSub * Add regression test for 2875 * Port API to gazebo9 Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

Prepare for 9.18.0 (gazebosim#2997)

e714bc9

Add warning if GAZEBO_RESOURCE_PATH may not be set correctly (gazebos…

d4525ae

…im#2991) * Add error message to RT shader * Improve error message for loading worlds/empty.world Signed-off-by: Audrow Nash <[email protected]>

Check for SDF files containing sibling elements of the same type with…

1a69fa6

… the same name (Gazebo9) (gazebosim#3016) * Initial implementation of SDF checking feature Co-authored-by: Jenn Nguyen <[email protected]>

Prepare 9.19.0 release (gazebosim#3020)

e4400ae

* Update version * Update Changelog

Require sdformat 6.3.0 or greater (gazebo9) (gazebosim#3022)

6deb6ef

Find tbb version < 2021 with pkg-config (gazebosim#3037)

f8b4d09

We currently don't support 2021 and newer, see gazebosim#2867. Signed-off-by: Steven Peters <[email protected]>

move multilink worlds to to test (gazebosim#3059)

13b7605

Signed-off-by: Ian Chen <[email protected]>

Install Profiler headers (gazebosim#3032)

9de9a42

Merge pull request gazebosim#3062 from osrf/backport_3031

4b1fa4d

Backport gazebosim#3031 - Make links within nested models modifiable from GUI Client

Backport PR gazebosim#3030 to Gazebo9 for CURL fixes (gazebosim#3041)

16b99c6

Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Steve Peters <[email protected]>

Fix light preview parameters (gazebosim#2982)

94afbb1

Signed-off-by: Martin Pecka <[email protected]> Co-authored-by: Louise Poubel <[email protected]>

Fix missing namespace for string (gazebosim#3211)

f37fd3c

Fix focal builds: use python3 with check_test_ran.py (gazebosim#3155) (…

e014863

…gazebosim#3278) * Use find_package(Python3) with newer cmake Signed-off-by: Steve Peters <[email protected]>

Make CameraVisual distance depend on horizontal_fov

aa31ed2

ahcorde approved these changes Mar 20, 2023

View reviewed changes

InigoMoreno changed the base branch from gazebo9 to gazebo11 January 8, 2024 08:32

InigoMoreno requested review from scpeters and traversaro as code owners January 8, 2024 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Camera visual fov fix #3307

Camera visual fov fix #3307

InigoMoreno commented Mar 17, 2023 •

edited

Loading

talregev commented Oct 17, 2023 •

edited

Loading

traversaro commented Jan 8, 2024

Camera visual fov fix #3307

Are you sure you want to change the base?

Camera visual fov fix #3307

Conversation

InigoMoreno commented Mar 17, 2023 • edited Loading

🦟 Bug fix

Summary

Checklist

talregev commented Oct 17, 2023 • edited Loading

traversaro commented Jan 8, 2024

InigoMoreno commented Mar 17, 2023 •

edited

Loading

talregev commented Oct 17, 2023 •

edited

Loading