Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3334: Fix Gremlin Reusing Accumulo Iterators #3335

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Nov 18, 2024

Moves Gremlin away from reusing the raw iterator passed back from the operation to instead buffering to a set first before continuing hopefully increasing performance.

Related issue

@tb06904 tb06904 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Nov 18, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Nov 18, 2024
@tb06904 tb06904 requested review from cn337131 and p29876 November 18, 2024 17:29
@tb06904 tb06904 linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.00%. Comparing base (960c599) to head (eda0193).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rpop/process/traversal/util/GafferVertexUtils.java 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3335      +/-   ##
=============================================
- Coverage      68.01%   68.00%   -0.01%     
  Complexity      2596     2596              
=============================================
  Files            955      954       -1     
  Lines          30564    30554      -10     
  Branches        3376     3375       -1     
=============================================
- Hits           20787    20779       -8     
+ Misses          8302     8301       -1     
+ Partials        1475     1474       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

cn337131
cn337131 previously approved these changes Nov 19, 2024
p29876
p29876 previously approved these changes Nov 19, 2024
@ms9698 ms9698 dismissed stale reviews from p29876 and cn337131 November 20, 2024 11:00

The merge-base changed after approval.

@tb06904 tb06904 force-pushed the gh-3334-make-gremlin-not-reuse-accumulo-iterators branch from 6eda5f4 to 2375e1a Compare November 20, 2024 14:40
cn337131
cn337131 previously approved these changes Nov 20, 2024
p29876
p29876 previously approved these changes Nov 20, 2024
@tb06904 tb06904 dismissed stale reviews from p29876 and cn337131 via 8451fd9 November 20, 2024 17:33
@wb36499 wb36499 merged commit 3b93f97 into develop Nov 21, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3334-make-gremlin-not-reuse-accumulo-iterators branch November 21, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Gremlin not reuse Accumulo Iterators
4 participants