Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3351: Better GetWalks support on federated POC #3352

Merged
merged 11 commits into from
Jan 13, 2025

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Jan 10, 2025

Fixes a few issues for GetWalks when running on new federated POC along with some general bug fixes for it too.
Main changes:

  • GetWalks.flatten() no longer gives all the operations get walks will run as this removes all the information about the operation can can be very misleading in an operation chain.
  • OperationChainHandler can now apply all operation options on the top level chain to all child operations.
  • Bug fix to GetWalks as it did not treat an allEdges: true as a valid hop.

Related issue

@tb06904 tb06904 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Jan 10, 2025
@tb06904 tb06904 added this to the 2.4.0 milestone Jan 10, 2025
@tb06904 tb06904 requested review from cn337131 and p29876 January 10, 2025 16:32
@tb06904 tb06904 linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.08%. Comparing base (d41a74b) to head (b879931).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...va/uk/gov/gchq/gaffer/operation/impl/GetWalks.java 0.00% 1 Missing and 2 partials ⚠️
...affer/store/operation/handler/GetWalksHandler.java 25.00% 3 Missing ⚠️
...store/operation/handler/OperationChainHandler.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3352      +/-   ##
=============================================
+ Coverage      68.04%   68.08%   +0.04%     
  Complexity      2596     2596              
=============================================
  Files            957      957              
  Lines          30662    30670       +8     
  Branches        3398     3399       +1     
=============================================
+ Hits           20863    20881      +18     
+ Misses          8314     8304      -10     
  Partials        1485     1485              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wb36499 wb36499 merged commit 4eee4de into develop Jan 13, 2025
27 of 29 checks passed
@wb36499 wb36499 deleted the gh-3351-better-getwalks-support-on-federated-poc branch January 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better GetWalks support on Federated POC
4 participants