Ensure AGI_LocusCode IDs are compacted in oio:id values. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Let's take a swing. I'll merge now and we can double check at the next outage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #106. This is kind of a hack, but that fits the theme of
fix-obo-uris.pl.AGI_LocusCodeIDs don't seem to be given theoboInOwl:idcompacted value by the OWL API parser, due to the underscore within the prefix.Alternatively we could use a different prefix for these identifiers, but I'm not sure of the origin of this particular prefix and who else uses it.
I believe that if the compacted form is in the ontology as an
oboInOwl:idvalue, things should look correct in the Solr load.