Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Fix deprecated matplotlib plotting option in monitoring by scipy #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fzeiser
Copy link

@fzeiser fzeiser commented Oct 29, 2019

This pull request fixes the the deprecated command mlab.normpdf (since 2.2) and used scipy's scipy.stats.norm instead. However, I didn't find where you list requirements of fbu, as scipy should obviously be a requirement then.

Copy link
Collaborator

@francescorubbo francescorubbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only explicit requirement is pymc3 in the setup.py script:
https://github.com/gerbaudo/fbu/blob/master/setup.py#L20

Indeed it would be better to have a requirements.txt (and CI, linter, etc..), but I'm no longer actively maintaining this project unfortunately.
There was also an effort at some point to move the project here: https://github.com/pyFBU

@@ -1,14 +1,15 @@
import matplotlib.mlab as mlab
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused import

@clementhelsens
Copy link
Collaborator

Hello, to confirm what @francescorubbo said, the developments are now going on in https://github.com/pyFBU, where we have for example added a first implementation of gammas as nuisance parameters (for statistical component of Monte-Carlo)

@fzeiser
Copy link
Author

fzeiser commented Oct 29, 2019

Shall I move the pull request over there?

I think it would be nice to mark this repo as archived and link to https://github.com/pyFBU. I don't see many issues/pull requests there. Which are the working branches? + There is two pull requests here which should be considered to be pulled over. The idea/fix in #66 helped me for example to get nuts working ;P

@clementhelsens
Copy link
Collaborator

yes please move the PR there. I agree the developments are not visible, but they are ongoing here:
https://github.com/Revile77/fbu/tree/background-gammas-improvements
I'm sorry we were not able to update the main code, but we are in an analysis rush, and we don't want to push code to the main repo that still needs improvements, but I'll ask the developer to make a WIP PRs. I will take care of arxiving the repo, thanks for the reminder.

@clementhelsens
Copy link
Collaborator

@gerbaudo I do not have rights to change the settings in this repository, would you mind archiving the repository and point to https://github.com/pyFBU when you have a moment?
thanks,
Clement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants