Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Uncomment more preprocessor tests #18534

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jan 20, 2025

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 10:48
@jketema jketema requested a review from a team as a code owner January 20, 2025 10:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • cpp/ql/test/library-tests/preprocessor/preprocessor/pp.cpp: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/pp.h: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/preproc.expected: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the C++ label Jan 20, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume these macros were causing something terrible to happen at some point previously.

@jketema
Copy link
Contributor Author

jketema commented Jan 20, 2025

I assume these macros were causing something terrible to happen at some point previously.

That's what I suspect too.

@jketema jketema merged commit 1b2d7bc into github:main Jan 20, 2025
8 checks passed
@jketema jketema deleted the uncomment branch January 20, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants