fix #1038

Expressions such as `[a: 1 2 3]` should be equivalent to `[{a: 1}, 2, 3]` and not `[{a: 1, 2: 2, 3: 3}]`. Property shorthand, including atomic identifiers/literals as shorthand for key-value pairs with the atom as the key and value, should not work outside of braces.
gkz · Oct 25, 2018 · bc1c188 · pepkin88 · Oct 29, 2018 · bc1c188
1 parent 29c9c51
commit bc1c188
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/lib/lexer.js b/lib/lexer.js
diff --git a/src/lexer.ls b/src/lexer.ls
@@ -31,8 +31,8 @@ exports <<<
         add-implicit-indentation it
         rewrite-blockless it
         add-implicit-parentheses it
-        add-implicit-braces it
         expand-literals it
+        add-implicit-braces it
         it.shift! if it.0?.0 is 'NEWLINE'
         it
 

diff --git a/test/literal.ls b/test/literal.ls
@@ -364,6 +364,17 @@ a = Array do
 eq 2, a.length
 eq 2, (Array 1: 2, 3).length
 
+# [LiveScript#1038](https://github.com/gkz/LiveScript/issues/1038):
+# More cases of not consuming shorthand properties.
+a = [a: 1 2 3]
+eq 3 a.length
+
+fn = (x, y, z) -> z
+eq 3 fn a: 1 2 3
+
+e = try LiveScript.compile 'x = a: 1 2' catch e
+eq "Parse error on line 1: Unexpected ','" e.message
+
 
 # With leading comments.
 obj =