-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
responderListFilePath as an object #40
Open
stephane-tessier
wants to merge
19
commits into
goddyZhao:master
Choose a base branch
from
stephane-tessier:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephane-tessier
force-pushed
the
master
branch
from
January 29, 2016 13:53
0194cdc
to
941bb79
Compare
I wanna be able to give an options object via nodejs (`nproxy(port, options)`), and pass the `responderListFilePath` directly as an object. Maybe this is not the cleanest way to do this, but I didn't want to refactorize too much code.
updating url repo in package.json
Fix: no file watcher if direct configuration
stephane-tessier
force-pushed
the
master
branch
2 times, most recently
from
February 1, 2016 11:01
2480a6d
to
2ede365
Compare
stephane-tessier
force-pushed
the
master
branch
from
February 1, 2016 11:15
2ede365
to
0a357c4
Compare
deprecated fix + updates deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna be able to give an options object via nodejs (
nproxy(port, options)
), and pass theresponderListFilePath
option directly as an object.Maybe this is not the cleanest way to do this, but I didn't want to refactorize too much code.