QS8 / QU8 PReLU microkernels #7738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamipreksha
commented
Jan 30, 2025
swamipreksha
commented
- Implementations for various ISAs:
- x86 AVX2
- Scalar ISA
- Unit tests
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
swamipreksha
force-pushed
the
qs8_qu8_vprelu
branch
from
2adbcf3 to
4af1bc9
Compare
swamipreksha
commented
Jan 31, 2025
dsharlet
reviewed
Feb 3, 2025
src/qs8-vpreluc/avx2.c.in
Outdated
| __m256i vacc${N} = _mm256_blendv_epi8(va${N}_sub, _mm256_mullo_epi32(va${N}_sub, vslope), _mm256_cmpgt_epi32(_mm256_setzero_si256(), va${N}_sub)); | ||
|
|
||
| $for N in range(2*SIMD_TILE): | ||
| __m256 vscale${N} = _mm256_blendv_ps(vnegative_multiplier, vpositive_multiplier, _mm256_castsi256_ps(_mm256_cmpgt_epi32(va${N}_sub, _mm256_setzero_si256()))); |
There was a problem hiding this comment.
Use the same condition here too? Both for consistency, and to rely less on compiler smartness to effectively do CSE. In fact, consider computing the comparison explicitly with an intermediate?
There was a problem hiding this comment.
We have addressed all your reviews. Kindly let us know if any other change is required.
swamipreksha
force-pushed
the
qs8_qu8_vprelu
branch
from
4af1bc9 to
cfac799
Compare
dsharlet
reviewed
Feb 5, 2025
swamipreksha
force-pushed
the
qs8_qu8_vprelu
branch
3 times, most recently
from
aa81513 to
fee5c12
Compare
- Implementations for various ISAs: - x86 AVX2 - Scalar ISA - Unit tests Signed-Off-by: Ravi Kumar Soni <[email protected]> Signed-off-by: Swami, Preksha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.