Zero masked arithmetic operations #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jan-wassenberg
requested changes
Jan 6, 2025
wbb-ccl
force-pushed
the
cc_up_masked_arithmetic
branch
2 times, most recently
from
439cc55 to
3ab06f2
Compare
Remove OrZero suffixes for consistency Rename MaskedDIvide for consistency Rename HWY_SVE_RETV_ARGMVVZ etc. for consistency Undef all new macros at end of file Remove unused macro Remove unnecessary wrapper functions Remove MulLower, the rest of this implementation is in google#2429 Remove docs for ops not in this branch Add missing MaskedMax op Consolidate MulAdd tests
wbb-ccl
force-pushed
the
cc_up_masked_arithmetic
branch
from
a927dd0 to
b4c66f7
Compare
jan-wassenberg
approved these changes
Feb 4, 2025
|
This one also failed due to a shadowed local variable at masked_arithmetic_test.cc:636, sorry I didn't see that. |
jan-wassenberg
requested changes
Feb 4, 2025
jan-wassenberg
approved these changes
Feb 4, 2025
|
CI looks good, hopefully will be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
Max(a, b)[i]orzeroifm[i]is falsea[i] + b[i]or0ifm[i]is false.a[i] - b[i]or0ifm[i]is false.a[i] * b[i]or0ifm[i]is false.a[i] / b[i]or0ifm[i]is false.a[i] + b[i]saturated to the minimum/maximum representable value, or0if m[i]` is false.a[i] - b[i]saturated to the minimum/maximum representable value, or0if m[i]` is false.0ifm[i]is false.a[i] * b[i] + c[i]or0ifm[i]is false.-a[i] * b[i] + c[i]or0ifm[i]is false.aandbtoTFromD<D>and computesa[2*i+1]*b[2*i+1] + a[2*i+0]*b[2*i+0], or0ifm[i]is false.Testing is included for all operations where both the masking and the underlying operation is tested.