Various masked operations #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jan-wassenberg
requested changes
Jan 6, 2025
wbb-ccl
force-pushed
the
cc_up_masked_ops
branch
from
504b82d to
d76ec00
Compare
jan-wassenberg
requested changes
Jan 30, 2025
jan-wassenberg
previously approved these changes
Jan 30, 2025
Remove OrZero suffix and fix MaskedOr docs Update naming of masked table lookups to follow convention Optimise MaskedReduceMin/Max Add TODOs Remove the masked table lookups To be added alongside the platform specialisations Remove unused macros Rename HWY_SVE_RETV_ARGMVVZ to follow convention
wbb-ccl
force-pushed
the
cc_up_masked_ops
branch
from
7ca5f54 to
af4183d
Compare
|
FYI this is stuck behind a failing internal test which seems to be fixed. Re-starting.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
a[i] || b[i]orzeroifm[i]is false.TwoTablesLookupLanes(V a, V b, unspecified)wherem[i]is true, anda[i]wherem[i]is false.TwoTablesLookupLanes(V a, V b, unspecified)wherem[i]is true, and zero wherem[i]is false.m[i]istrue.m[i]istrue.m[i]istrue.mask[i] < 0 ? (-v[i]) : ((mask[i] > 0) ? v[i] : impl_defined_val), whereimpl_defined_valis an implementation-defined value that is equal to either 0 orv[i]. SVE included only.Testing is performed for all new operations.