-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new class ParseWithOptions #3730
Open
KarolJakubKrawiec
wants to merge
13
commits into
google:master
Choose a base branch
from
KarolJakubKrawiec:parseWithOptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+864,101
−95
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed15e47
Add parsingOptions to OpenSource
KarolJakubKrawiec f5c2748
Create new class ParsingOptions
KarolJakubKrawiec 809f889
Add parsingOptions to OpenSource
KarolJakubKrawiec 45cb5e4
Create new class ParsingOptions
KarolJakubKrawiec 90270c7
Write testcases for parseWithOptions
KarolJakubKrawiec 5155f58
Rewrite comments
KarolJakubKrawiec 9d7975a
Create ParsingOptions for cpp
KarolJakubKrawiec 1a8629e
Updated (NON FUNCTIONAL) Version of ParseWithOptions
KarolJakubKrawiec ddcfb51
ParsingOptions update (non functional)
KarolJakubKrawiec 2b6d054
ParseWithOptions Opensource CPP Version
KarolJakubKrawiec 65f0f44
Merge branch 'google:master' into parseWithOptions
KarolJakubKrawiec 35f998d
Merge branch 'google:master' into parseWithOptions
KarolJakubKrawiec d9d2ef0
Solved mistakes for ParseWithOptions
KarolJakubKrawiec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
855,021 changes: 855,021 additions & 0 deletions
855,021
cpp/src/phonenumbers/geocoding/geocoding_data.cc
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// Copyright (C) 2009 The Libphonenumber Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include "phonenumbers/parsingoptions.h" | ||
|
||
namespace i18n { | ||
namespace phonenumbers { | ||
|
||
ParsingOptions& ParsingOptions::SetDefaultRegion( | ||
const std::string& default_region) { | ||
default_region_ = default_region; | ||
return *this; | ||
} | ||
|
||
ParsingOptions& ParsingOptions::SetKeepRawInput(bool keep_raw_input) { | ||
keep_raw_input_ = keep_raw_input; | ||
return *this; | ||
} | ||
|
||
} // namespace phonenumbers | ||
} // namespace i18n |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// Copyright (C) 2009 The Libphonenumber Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef I18N_PHONENUMBERS_PARSINGOPTIONS_H_ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add the license header. |
||
#define I18N_PHONENUMBERS_PARSINGOPTIONS_H_ | ||
|
||
#include <string> | ||
|
||
namespace i18n { | ||
namespace phonenumbers { | ||
|
||
// Options for parsing a phone number. To be used with the ParseWithOptions | ||
// method. | ||
// Example: | ||
// ParsingOptions().SetDefaultRegion("US").SetKeepRawInput(true); | ||
class ParsingOptions { | ||
public: | ||
ParsingOptions() : default_region_("ZZ"), keep_raw_input_(false) {}; | ||
|
||
// Set the value for default_region_. | ||
ParsingOptions& SetDefaultRegion( | ||
const std::string& default_region); | ||
|
||
// Set the value for keep_raw_input_. | ||
ParsingOptions& SetKeepRawInput(bool keep_raw_input); | ||
|
||
private: | ||
friend class PhoneNumberUtil; | ||
|
||
// The region we are expecting the number to be from. This is ignored if the | ||
// number being parsed is written in international format. In case of national | ||
// format, the country_code will be set to the one of this default region. If | ||
// the number is guaranteed to start with a '+' followed by the country | ||
// calling code, then "ZZ" or null can be supplied. | ||
std::string default_region_; | ||
|
||
// Whether the raw input should be kept in the PhoneNumber object. If true, | ||
// the raw_input field and country_code_source fields will be populated. | ||
bool keep_raw_input_; | ||
}; | ||
|
||
} // namespace phonenumbers | ||
} // namespace i18n | ||
|
||
#endif // I18N_PHONENUMBERS_PARSINGOPTIONS_H_ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the license header.