Enhancement/9935 features copy edit #10057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 59efe60 are ready:
|
|
Size Change: +11 B (0%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
|
JS tests are failing for non related reasons |
eugene-manuilov
requested changes
Jan 20, 2025
| 'Reader Revenue Manager publication tracking (your Reader Revenue Manager account will still remain active)', | ||
| 'Users will no longer be able to sign in to your WordPress site using their Google Accounts.', | ||
| 'Users will not be able to create an account on your site using their Google Account (if account creation is enabled).', | ||
| "Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress' “Reset my password” to set a password for their account.", |
There was a problem hiding this comment.
Suggested change
| "Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress' “Reset my password” to set a password for their account.", | |
| 'Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account.', |
| 'google-site-kit' | ||
| ), | ||
| __( | ||
| 'Existing users who have only used Sign in with Google to sign in to your site will need to use WordPress\' "Reset my password" to set a password for their account', | ||
| "Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress' “Reset my password” to set a password for their account.", |
There was a problem hiding this comment.
Suggested change
| "Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress' “Reset my password” to set a password for their account.", | |
| 'Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account.', |
|
Thanks @eugene-manuilov PR updated P.S Tests are failing for unrelated changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist