Finish refactoring legacy stories.

[benbowler]

Summary

Addresses issue:

• Complete refactor of legacy stories #9882

Relevant technical choices

Completed the Storybook refactor of legacy stories!

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.
• Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[benbowler]

Awaiting the dependent branch to be merged.

[github-actions]

Build files for 51c3583 have been deleted.

[github-actions]

Size Change: 0 B

Total Size: 1.98 MB

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	62.2 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css	846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	8.48 kB
./dist/assets/js/33-********************.js	2.76 kB
./dist/assets/js/34-********************.js	2.25 kB
./dist/assets/js/35-********************.js	3.64 kB
./dist/assets/js/36-********************.js	936 B
./dist/assets/js/37-********************.js	893 B
./dist/assets/js/38-********************.js	1.61 kB
./dist/assets/js/39-********************.js	1.57 kB
./dist/assets/js/40-********************.js	1.61 kB
./dist/assets/js/41-********************.js	1.59 kB
./dist/assets/js/42-********************.js	1.83 kB
./dist/assets/js/43-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	901 B
./dist/assets/js/googlesitekit-activation-********************.js	24 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	54.2 kB
./dist/assets/js/googlesitekit-adminbar-********************.js	34.8 kB
./dist/assets/js/googlesitekit-api-********************.js	10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js	6.18 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js	10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js	25.6 kB
./dist/assets/js/googlesitekit-data-********************.js	2.37 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.94 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js	20.2 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	10 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js	28.2 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	82.6 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js	646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js	624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js	630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js	712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js	675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js	634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js	657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js	633 B
./dist/assets/js/googlesitekit-i18n-********************.js	3.93 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js	167 kB
./dist/assets/js/googlesitekit-metric-selection-********************.js	52 kB
./dist/assets/js/googlesitekit-modules-********************.js	22.3 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js	35.8 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js	119 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	190 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	22.6 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js	40.1 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js	69.2 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js	31.6 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32.2 kB
./dist/assets/js/googlesitekit-notifications-********************.js	37.9 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	377 B
./dist/assets/js/googlesitekit-reader-revenue-manager-block-editor-********************.js	477 B
./dist/assets/js/googlesitekit-settings-********************.js	127 kB
./dist/assets/js/googlesitekit-splash-********************.js	68.7 kB
./dist/assets/js/googlesitekit-user-input-********************.js	43.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js	323 kB
./dist/assets/js/googlesitekit-widgets-********************.js	102 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	63.3 kB
./dist/assets/js/runtime-********************.js	1.4 kB

_{compressed-size-action}

[techanvil]

Hi @benbowler, great work on this migration, it's quite a task.

I've identified a number of scenarios that we should fix and retain in some form. I've also left a handful of other comments. Please take a look.

Also noting that I've again been doing QA:Eng testing as part of the CR process, so once you've addressed the review comments I can review the new/affected stories and wrap up the QA as well.

[benbowler]

Thanks @techanvil, lots to review here too! I have addressed your comments. As an additional change I moved the Search Console module settings components to match all other modules.

[techanvil]

Thanks @benbowler! This is looking great. Just a couple more comments from me to address and this should be good to go.

[techanvil]

Thanks @benbowler!

Looks like you missed this comment on my previous review though, #9941 (comment)

Once that is addressed this will be good to go.

[techanvil]

Thanks @benbowler, that's great!

Please note, I pushed a commit to address the last stories referenced in this comment which needed an update to ensure the snippet toggle was displayed.

I've confirmed the failing JS and E2E tests are unrelated to the changes in this PR.

Top work, LGTM, and good to go!

✅