Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error reporting tag and service context information to structured logging #14257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielwinkler
Copy link

This will allow to configure the logging in a way that we get nicer error reporting

  • ErrorReportingLogLevel allows to specify a log level, at which logs will be picked up by the error reporting
  • ServiceIdentifier and ServiceVersion allow to specify the service annotation that will be used by the error reporting for grouping

@danielwinkler danielwinkler requested a review from a team as a code owner February 12, 2025 14:09
Copy link

google-cla bot commented Feb 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@danielwinkler danielwinkler force-pushed the feature/add-error-reporting branch from e1f7109 to e2ca971 Compare February 12, 2025 14:32
@danielwinkler danielwinkler force-pushed the feature/add-error-reporting branch from e2ca971 to be1bbc6 Compare February 12, 2025 14:32
@amanda-tarafa
Copy link
Contributor

Thanks for your PR. Can you please create an issue where we can disccuss in more details what you want to achieve and why you need to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants