Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Google.Cloud.Kms.V1] Support PQC asymmetric signing algorithms ML_DSA_65 and SLH_DSA_SHA2_128s #14278

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat: [Google.Cloud.Kms.V1] Support PQC asymmetric signing algorithms ML_DSA_65 and SLH_DSA_SHA2_128s #14278

merged 1 commit into from
Feb 18, 2025

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 18, 2025

  • Regenerate this pull request now.

feat: Add a PublicKeyFormat enum to allow specifying the format the public is going to be exported in

PiperOrigin-RevId: 728208243

Source-Link: googleapis/googleapis@0c860e0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/904854fd4af35ecca03c86404820031a9ec8f7ad
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuS21zLlYxLy5Pd2xCb3QueWFtbCIsImgiOiI5MDQ4NTRmZDRhZjM1ZWNjYTAzYzg2NDA0ODIwMDMxYTllYzhmN2FkIn0=

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot
feat: Support PQC asymmetric signing algorithms ML_DSA_65 and SLH_DSA…
4a585a8 
…_SHA2_128s

feat: Add a PublicKeyFormat enum to allow specifying the format the public is going to be exported in

PiperOrigin-RevId: 728208243

Source-Link: googleapis/googleapis@0c860e0

Source-Link: googleapis/googleapis-gen@904854f
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuS21zLlYxLy5Pd2xCb3QueWFtbCIsImgiOiI5MDQ4NTRmZDRhZjM1ZWNjYTAzYzg2NDA0ODIwMDMxYTllYzhmN2FkIn0=
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review February 18, 2025 18:22
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 18, 2025 18:22
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Kms_V1 branch from a2cf42a to 4a585a8 Compare February 18, 2025 18:22
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 18, 2025 18:22
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
Finding changes in Google.Cloud.Kms.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'ChecksummedData' added.
Enum 'CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm' entry 'PqSignMlDsa65' added.
Enum 'CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm' entry 'PqSignSlhDsaSha2128S' added.
Class 'GetPublicKeyRequest'; property 'PublicKey.Types.PublicKeyFormat PublicKeyFormat { get; set; }' added.
Class 'GetPublicKeyRequest'; constant 'System.Int32 Google.Cloud.Kms.V1.GetPublicKeyRequest::PublicKeyFormatFieldNumber' added.
Class 'PublicKey'; property 'ChecksummedData PublicKey_ { get; set; }' added.
Class 'PublicKey'; property 'PublicKey.Types.PublicKeyFormat PublicKeyFormat { get; set; }' added.
Class 'PublicKey'; constant 'System.Int32 Google.Cloud.Kms.V1.PublicKey::PublicKey_FieldNumber' added.
Class 'PublicKey'; constant 'System.Int32 Google.Cloud.Kms.V1.PublicKey::PublicKeyFormatFieldNumber' added.
Class 'PublicKey.Types' added.
Enum 'PublicKey.Types.PublicKeyFormat' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.Kms.V1 version 3.15.0
Differences from 3.15.0
Minor changes:
Class 'ChecksummedData' added.
Enum 'CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm' entry 'PqSignMlDsa65' added.
Enum 'CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm' entry 'PqSignSlhDsaSha2128S' added.
Class 'GetPublicKeyRequest'; property 'PublicKey.Types.PublicKeyFormat PublicKeyFormat { get; set; }' added.
Class 'GetPublicKeyRequest'; constant 'System.Int32 Google.Cloud.Kms.V1.GetPublicKeyRequest::PublicKeyFormatFieldNumber' added.
Class 'PublicKey'; property 'ChecksummedData PublicKey_ { get; set; }' added.
Class 'PublicKey'; property 'PublicKey.Types.PublicKeyFormat PublicKeyFormat { get; set; }' added.
Class 'PublicKey'; constant 'System.Int32 Google.Cloud.Kms.V1.PublicKey::PublicKey_FieldNumber' added.
Class 'PublicKey'; constant 'System.Int32 Google.Cloud.Kms.V1.PublicKey::PublicKeyFormatFieldNumber' added.
Class 'PublicKey.Types' added.
Enum 'PublicKey.Types.PublicKeyFormat' added.

Diff level: Minor

Finished comparisons for Google.Cloud.Kms.V1

@amanda-tarafa amanda-tarafa merged commit 0f261f0 into main Feb 18, 2025
12 checks passed
@amanda-tarafa amanda-tarafa deleted the owl-bot-copy-apis-Google_Cloud_Kms_V1 branch February 18, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa amanda-tarafa approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amanda-tarafa