-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js example #284
base: main
Are you sure you want to change the base?
Add Node.js example #284
Conversation
05e7271
to
a5158d4
Compare
Thanks a lot for the contribution! We try to make the simplest example possible, therefore: Have you considered using zero-code? https://opentelemetry.io/docs/zero-code/js/ |
Thank you for your feedback and the recommendation @zeitlinger! I didn't know about the zero-code feature before. Also, I managed to reproduce the lint issues locally, and fixed them. As of the OATS, I was unable to reproduce locally. |
... and I wasn't aware that the auto-instrumentation has this limitation 😄 Agree - let's keep this and maybe add an auto-instrumentation example later.
great
did you see https://github.com/grafana/docker-otel-lgtm/blob/main/CONTRIBUTING.md ? |
I already saw a problem with a port - let's see if that fixes it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that you need the protobuf port based on the dependencies
environment: | ||
OTEL_SERVICE_NAME: "dice-server" | ||
OTEL_SERVICE_VERSION: "0.1.0" | ||
OTEL_EXPORTER_OTLP_ENDPOINT: http://lgtm:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTEL_EXPORTER_OTLP_ENDPOINT: http://lgtm:4317 | |
OTEL_EXPORTER_OTLP_ENDPOINT: http://lgtm:4318 |
Head branch was pushed to by a user without write access
d452d39
to
7a04cff
Compare
- Lint again files and disable javascript standard. It had a conflict with Prettier about this rule space-before-function-paren - Use proto port
7a04cff
to
c21c862
Compare
With this PR I add example app for Node.js.
The example is based on the Node.js app written in OpenTelemetry documentation (dice server)
Even though the OpenTelemetry lib for Logging in Node.js is still in development I use it in the example. It is working well