Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Render: Support Tracing #586
base: master
Are you sure you want to change the base?
Image Render: Support Tracing #586
Changes from 13 commits
d974217
eb1db17
bb8a21a
1a0ee72
c8ed844
4ff2f6c
7f10f00
36b1891
9eaa8cf
a741f58
71445a8
37cfaa7
45f4968
18e1d25
3f191e2
1eca03d
575c323
dcd3967
87f42d2
987f0e7
837f072
4d7f051
8e94864
6bc6e9b
4842979
57d7d5e
e2c0cef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenTelemetry needs to be initialized before the other modules (express, http, winston, etc) in order for it to auto capture telemetry trace data from those libraries so it must come first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm this is the case in the log output in terminal. You can check that
trace_id
,span_id
, andtrace_flags
is includedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed OpenTelemetry Doc for Node.js to implement this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file should be formatted using Prettier linter (we don't have a check for that in CI but we should do our best).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fs module is very noisy. It create 10+ traces with singular span so it did not make much sense to have it unless it's part of another trace.
There is a list of supported autoinstrumentation. We can opt out of any in the future we do not care to trace those libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create startTracing separately from the rest of initialization steps b/c we want to only capture traces if it's enabled