[tempo-distributed] Update distributor proxy routes for GET 2.3.0. #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
reviewed
Oct 16, 2023
charts/tempo-distributed/values.yaml
Outdated
| otlp/grpc: | ||
| url: h2c://{{ template "tempo.fullname" . }}-distributor.{{ .Release.Namespace }}.svc:4317 | ||
| otlp/http: | ||
| url: http://{{ template "tempo.fullname" . }}-distributor.{{ .Release.Namespace }}.svc:{{ include "tempo.serverHttpListenPort" . }} |
There was a problem hiding this comment.
The otlp/http ingest is separate from the tempo api, so we will end up with 3 distributor routings.
Distributor:url - tempo server listen port
otlp/grpc: 4317
otlp/http: 4318
There was a problem hiding this comment.
Thank you! Have updated.
According to the Grafana Loki [documentation](https://grafana.com/docs/loki/latest/get-started/hash-rings/): * the query scheduler must be part of a hashring * the index gateway may optionally be part of a hashring This PR updates the chart such that the query scheduler and index gateway pods will expose the memberlist container port 7946, and include the member list selector label. The index gateway may optionally be prevented from joining the memberlist by setting `.Values.indexGateway.joinMemberlist` to false (default true), reflecting the current state of the documentation. Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
GET 2.3.0 now includes functionality that allows the gateway to accept traces both via OTLP gRPC and HTTP. Also includes ability to define own proxy routes as a flag existed to enable this, but no configuration was available to set them. Signed-off-by: Heds Simons <[email protected]>
hedss
requested review from
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
zalegrala
approved these changes
Jan 4, 2024
…P URL. Signed-off-by: Heds Simons <[email protected]>
mdisibio
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes ability to define own proxy routes as a flag existed to enable this, but no configuration was available to set them.