Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tempo-distributed] Static ports #3501

Closed
wants to merge 115 commits into from
Closed

[tempo-distributed] Static ports #3501

wants to merge 115 commits into from

Conversation

xogoodnow
Copy link
Contributor

Hi,

None of the service/port related configurations for gateway were actually dynamic.
Also changed the probe so the parameters could be configured

Cheers

@xogoodnow
Copy link
Contributor Author

I see that almost all other services (except for metrics-generator) are static.
Will change the templates

@xogoodnow
Copy link
Contributor Author

xogoodnow commented Dec 22, 2024 •
edited
Loading

I went through almost all services and mildly modified the templates so the ports could be modified dynamically.

  1. If the ports section are there so folks would be able to change the ports, they must not be set statically but if the section is just informative, we can commit them all and just provide a link to the documentation.
  2. This way changing any default port would be possible in the future

Cheers

jimmybchopps and others added 21 commits January 25, 2025 16:29
@jimmybchopps @xogoodnow
Updated pod labels to include all labels
0c10a7c 
Signed-off-by: Jimmy Bourque <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@jimmybchopps @xogoodnow
Revert "Resolving conflict"
0c6d026 
This reverts commit 531e7ef.

Signed-off-by: xogoodnow <[email protected]>
@jimmybchopps @xogoodnow
Resolving conflict
a631ecd 
Signed-off-by: Jimmy Bourque <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@56quarters @xogoodnow
[rollout-operator] Bump rollout-operator version to 0.20.0
9f7001a 
Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@zanhsieh @xogoodnow
Update Chart.yaml
432f272 
Signed-off-by: MH <[email protected]>

Signed-off-by: MH <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Added resource limit and request samples for all components
9a4f568 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Added limits to Minio,admin-api and enterprise gateway
56ad3c0 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
bumped chart version
bdfe453 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Commented the resource section for enterprise gateway
1cd8066 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
bumped the chart number
1575796 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Ran helm-docs
4fa1d61 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Ran helm-docs
7bd8c7a 
Signed-off-by: xogoodnow <[email protected]>
@martinbalint @xogoodnow
[tempo-distributed] Added option persistentVolumeClaimRetentionPolicy…
0f6e032 
… to StatefulSet

Signed-off-by: Martin Balint <[email protected]>
@faridtmammadov @xogoodnow
add query frontend metrics config to tempo distributed helm chart
9035198 
Signed-off-by: Farid Mammadov <[email protected]>
@michaelruigrok @xogoodnow
values.yaml: update alerting examples and ref
aa41129 
add missing configuration sections from grafana alerting block

Signed-off-by: Michael Ruigrok <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@zanhsieh @xogoodnow
Update Chart.yaml
6c82dd4 
Signed-off-by: MH <[email protected]>

Signed-off-by: MH <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@SimKev2 @xogoodnow
Remove duplicated ingester podLabels
ea1c399 
Signed-off-by: Kevin Simons <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@charleskorn @xogoodnow
Update rollout-operator chart with latest version
8f2392e 
Signed-off-by: Charles Korn <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@cbos @xogoodnow
Add configuration options for the number of retries done by the sidec…
dae9ff2 
…ar. During startup phase some more time might be needed to complete the actions.

Signed-off-by: Cees Bos <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@cbos @xogoodnow
Update Chart.yaml, bump version to 8.6.4
0f320ad 
Signed-off-by: Cees Bos <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@KyriosGN0 @xogoodnow
add option to deploy podmonitor and add option to remove svc
ac73f09 
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
KyriosGN0 and others added 19 commits January 25, 2025 16:31
@KyriosGN0 @jkroepke @xogoodnow
Update charts/grafana/templates/service.yaml
3f3354a 
Co-authored-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@dastrobu @xogoodnow
add log_discarded_spans config for Tempo distributor to tempo-distrib…
6587a45 
…uted chart.

The new value enabled configuring `log_discarded_spans` like for `log_received_spans` as shown below:

```
distributor:
  config:
    log_discarded_spans:
      enabled: true
    log_received_spans:
      # ...
```

The feature was introduced in [tempo/#3964](grafana/tempo#3964).

Signed-off-by: Daniel Strobusch <[email protected]>
@Aza1250 @dastrobu @xogoodnow
[grafana] Fix session affinity bug (grafana#3529)
f491f6f 
Co-authored-by: Daniel Strobusch <[email protected]>
@marcofranssen @zanhsieh @xogoodnow
[grafana] Update downloadDashboards image to latest curl release (gra…
8ff3d45 
…fana#3534)

Co-authored-by: MH <[email protected]>
@xogoodnow
Fixed gateway port config static issue and added probe parameters
fd1f8ac 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed ingestor
8d4fe9e 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed distributor
d349aad 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed compactor
8e9d5d6 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed querier
018dfbc 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed queryFrontend and tempo-query
1ac9724 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed Federation-frontend
b30bda5 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Bumped version
820296d 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Updated tempo query
90defb9 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Updated config file
5d335bc 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed linter issue
f1334a4 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed linter issue
b7c958c 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Fixed linter issue
1ec6f7e 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Bad arguments
a38d68c 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Bad arguments
f1ae3b0 
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow xogoodnow closed this Jan 25, 2025
@xogoodnow xogoodnow mentioned this pull request Jan 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikh-Abubaker Sheikh-Abubaker Awaiting requested review from Sheikh-Abubaker Sheikh-Abubaker is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@swartz-k swartz-k Awaiting requested review from swartz-k swartz-k is a code owner

@BitProcessor BitProcessor Awaiting requested review from BitProcessor BitProcessor is a code owner

@faustodavid faustodavid Awaiting requested review from faustodavid faustodavid is a code owner

@Whyeasy Whyeasy Awaiting requested review from Whyeasy Whyeasy is a code owner

@dgzlopes dgzlopes Awaiting requested review from dgzlopes dgzlopes is a code owner

@jkroepke jkroepke Awaiting requested review from jkroepke jkroepke is a code owner

@maorfr maorfr Awaiting requested review from maorfr maorfr is a code owner

@torstenwalter torstenwalter Awaiting requested review from torstenwalter torstenwalter is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

@zanhsieh zanhsieh Awaiting requested review from zanhsieh zanhsieh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.